Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Kevin Grittner escribió:
>> That argument would be more persuasive if I could find any current >> usage of the namecpy() function anywhere in the source code. > > Well, its cousin namestrcpy is used in a lot of places. That one uses a > regular C string as source; namecpy uses a Name as source, so they are > slightly different but the coding is pretty much the same. Fair enough. > There is a difference in using the macro StrNCpy instead of the strncpy > library function directly. ISTM this makes sense because Name is known > to be zero-terminated at NAMEDATALEN, which a random C string is not. Is the capital T in the second #undef in this pg_locale.c code intended?: #ifdef WIN32 /* * This Windows file defines StrNCpy. We don't need it here, so we undefine * it to keep the compiler quiet, and undefine it again after the file is * included, so we don't accidentally use theirs. */ #undef StrNCpy #include <shlwapi.h> #ifdef StrNCpy #undef STrNCpy #endif #endif -- Kevin GrittnerEDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
