On Sat, Dec 7, 2013 at 11:07 PM, Joe Conway <m...@joeconway.com> wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 12/05/2013 07:05 PM, Joe Conway wrote: > > On 12/05/2013 06:53 PM, Tom Lane wrote: > >> I seem to remember that at some point we realized that the > >> encoding ID assignments are part of libpq's ABI and so can't > >> practically be changed ever, so the above may be moot. Even so, > >> I think it's a bad idea to be depending on pg_encoding_to_char() > >> here, given the ambiguity in what it references. It would be > >> unsurprising to get build-time or run-time failures on pickier > >> platforms, as a consequence of that ambiguity. So I'd still > >> recommend comparing integer IDs as above, rather than this. > > > > Great feedback as always -- thanks! Will make that change. > > Committed to all active branches. >
IMHO is more elegant create a procedure to encapsulate the code to avoid redundancy. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog sobre TI: http://fabriziomello.blogspot.com >> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello >> Twitter: http://twitter.com/fabriziomello