On 12/07/2013 05:50 PM, Joe Conway wrote: > On 12/07/2013 05:41 PM, Fabrízio de Royes Mello wrote: > >> On Sat, Dec 7, 2013 at 11:20 PM, Michael Paquier >> <michael.paqu...@gmail.com <mailto:michael.paqu...@gmail.com>> >> wrote: >>>> >>>> IMHO is more elegant create a procedure to encapsulate the code >>>> to avoid redundancy. >>> Yep, perhaps something like PQsetClientEncodingIfDifferent or >>> similar would make sense. > >> Well I think at this first moment we can just create a procedure >> inside the dblink contrib and not touch in libpq. > > Maybe a libpq function could be done for 9.4, but not for back branches. > > I don't think it makes sense to create a new function in dblink either > -- we're only talking about two lines of added redundancy which is > less lines of code than a new function would add. But if we create > PQsetClientEncodingIfDifferent() (or whatever) we can remove those > extra lines in 9.4 ;-)
Hey, since we're about to do 9.3.3: was this patch ever committed? -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
