On Fri, Dec 13, 2013 at 5:49 PM, Dilip kumar <dilip.ku...@huawei.com> wrote: > On Fri, Dec 13, 2013 at 11:25, Sawada Masahiko Wrote > >> >> I attached the patch which have modified based on Robert suggestion, >> >> and fixed typo. >> > >> > I have reviewed the modified patch and I have some comments.. >> > >> > 1. Patch need to be rebased (failed applying on head) >> > >> > 2. crc field should be at end in ControlFileData struct, because for >> crc calculation, it directly take the offset of crc field in >> ControlFileData. >> > >> > /* CRC of all above ... MUST BE LAST! */ >> > pg_crc32 crc; >> > + >> > + /* Enable logging WAL when updating hint bits */ >> > + bool wal_log_hintbits; >> > } ControlFileData; >> > >> > 3. wal_log_hintbits field should be printed in PrintControlValues >> function. >> > >> >> Thank you for reviewing the patch! >> I have modified the patch base on your comment, and I attached the v7 >> patch. > > Thanks, patch Looks fine to me, Marked as Ready for Committer. >
I really appreciate your reviewing the patch many times! Regards, ------- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
