On Fri, Dec 20, 2013 at 1:05 PM, Sawada Masahiko <sawada.m...@gmail.com> wrote: > On Fri, Dec 20, 2013 at 3:38 AM, Sawada Masahiko <sawada.m...@gmail.com> > wrote: >> On Thu, Dec 19, 2013 at 12:37 PM, Amit Kapila <amit.kapil...@gmail.com> >> wrote: >>> On Wed, Dec 18, 2013 at 11:30 AM, Michael Paquier >>> <michael.paqu...@gmail.com> wrote: >>>> On Wed, Dec 18, 2013 at 11:22 AM, Amit Kapila <amit.kapil...@gmail.com> >>>> wrote: >>>>> On Fri, Dec 13, 2013 at 7:57 PM, Heikki Linnakangas >>>>> <hlinnakan...@vmware.com> wrote: >>>>>> Thanks, committed with some minor changes: >>>>> >>>>> Should this patch in CF app be moved to Committed Patches or is there >>>>> something left for this patch? >>>> Nothing has been forgotten for this patch. It can be marked as committed. >>> >>> Thanks for confirmation, I have marked it as Committed. >>> >> >> Thanks! >> >> I attached the patch which changes name from 'wal_log_hintbits' to >> 'wal_log_hints'. >> It gained the approval of plural. >> > > Sorry the patch which I attached has wrong indent on pg_controldata. > I have modified it and attached the new version patch. Now that you send this patch, I am just recalling some recent email from Tom arguing about avoiding to mix lower and upper-case characters for a GUC parameter name: http://www.postgresql.org/message-id/30569.1384917...@sss.pgh.pa.us
To fullfill this requirement, could you replace walLogHints by wal_log_hints in your patch? Thoughts from others? Regards, -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
