-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/19/2014 08:50 AM, Alvaro Herrera wrote: > Joe Conway wrote: >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >> >> On 06/18/2014 08:50 PM, Joe Conway wrote: >>> On 06/18/2014 08:45 PM, Tom Lane wrote: >>>> Well, we usually think memory leaks are back-patchable bugs. >>>> I'm a bit worried about the potential performance impact of >>>> an extra memory context creation/deletion though. It's >>>> probably not noticeable in this test case, but that's just >>>> because dblink() is such a spectacularly expensive function. >>> >>> Probably so. I'll try to scrounge up some time to test the >>> performance impact of your patch. >> >> Not the most scientific of tests, but I think a reasonable one: > > Is this an assert-enabled build?
No: CFLAGS = -O2 -Wall -Wmissing-prototypes -Wpointer-arith - -Wdeclaration-after-statement -Wendif-labels - -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing - -fwrapv -fexcess-precision=standard -g CONFIGURE = '--prefix=/usr/local/pgsql-head' '--with-pgport=55437' '--enable-debug' '--enable-nls' '--with-pam' '--enable-thread-safety' '--with-openssl' '--with-krb5' '--with-includes=/usr/include/kerberosIV' '--with-includes=/usr/include/et' '--enable-integer-datetimes' '--with-libxml' '' 'build_alias=' 'host_alias=' 'target_alias=' 'DOCBOOKSTYLE=/usr/share/sgml/docbook/stylesheet/dsssl/modular' - -- Joe Conway credativ LLC: http://www.credativ.us Linux, PostgreSQL, and general Open Source Training, Service, Consulting, & 24x7 Support -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTowsYAAoJEDfy90M199hll48QAJVSEiaYAAG4f50OyYpS5uka y85ceg+EfE9UMG6FKbEK7z6+a0cQUumvuGOxd0TxztujHLvRCFqW+UlCALRwl5fi d169MI+GYucHoKUj/CObM6dM8qYKK8OAVsMerpNLs97kW2Qsny1Jt930RhHxUgZe ZyUvRsQssInMQ5JUcCy5IinENxhry9fhCMkMIIPVuCu4aF4DeIy7T/cBQkY3S+C3 5DcpHoubwcorL2lFZSpJorQ6w5bueHp0jVsWo1IfP/XlrRckaS1MIgW95YKKw/Ok //F/CoFd9nSkyFmvZw8JW2R9o8Tv1HTZTMvzVCFK7yJGGXRQeTLEGHbYMkkaHgtr piHf89p1wvYOMaGtjQ2pAp4oGjMQ2g3DefvmU3UiM2g9wQ9WgRBMkwnWl3IHms6g OkozqzNtpBVyAxgoumuD2ohdnoHt521v0W4vGisLMv5ZbxHbTZBDmHBptiRkSxYH i6jWlAnTPjXmjy335QQSMe17XAa/vE+0v3ut/vS80lGj+nAKiZnvd4XgR8VwAN8f 6qWU3E754ZnMdYaIrjdrcJ6F0L75tsvM/bS73IN+OsefiYM+BVPv4M2kiwUtOl3z sPNl1uedv5QeF/B/69FBr6zRVBMUoxy6NTdwhZEf4aL9WnIxRO461NOlcEbBNjaC Pds6HML5iBRZixluCHuM =7cT8 -----END PGP SIGNATURE----- -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers