* Michael Paquier (michael.paqu...@gmail.com) wrote: > On Wed, Feb 25, 2015 at 4:27 AM, Peter Eisentraut <pete...@gmx.net> wrote: > > On 2/23/15 1:27 AM, Michael Paquier wrote: > >>> I would like to have an extension in tree that also does this, so we > >>> > have a regression test of this functionality. > >> Sure. Here is one in the patch attached added as a test module. The > >> name of the module is regress_dynamic. Perhaps the name could be > >> better.. > > > > I was more thinking like we could use an existing module like file_fdw. > > Right. I forgot this one. A patch is attached to do so.
I'm always doing VPATH builds, but I believe there's still an outstanding question on this from Peter about if we need to add entries to .gitignore for, eg, sql/file_fdw.sql if these directories don't exist because otherwise those would show up to someone doing a git status and to Robert's point- if we need those anyway, it's probably better to have them be in those directories rather than up a level and referring to directories that don't exist in the tree. Having the extra directories already exist doesn't seem like a bad thing to me anyway. If they are causing confusion or something then perhaps a README could be added to let people know why they exist. I'm going to mark this back to 'waiting on author' in case there's something material that I've missed which you can clarify. I had started this review thinking to help move it along but after re-reading the thread and thinking about it for a bit, I came around to the other side and therefore think it should probably be rejected. We certainly appreciate the effort, of course. Thanks! Stephen
signature.asc
Description: Digital signature