That's a fair point Michael. I would be willing to make such a change, but since c doesn't have optional function arguments I'm not sure the least intrusive way to do that. Do you have a suggestion?
On Wednesday, August 17, 2016, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Thu, Aug 18, 2016 at 12:21 AM, Ryan Murphy <ryanfmur...@gmail.com > <javascript:;>> wrote: > > I have created a better patch (attached) that correctly escapes the shell > > arguments using PQExpBufferStr and the appendShellString function, as per > > Michael and Andres' suggestions. > > > > Further suggestions welcome of course. > > As far as I know, it is perfectly possible to have LF/CR in a path > name (that's bad practice btw...), and your patch would make initdb > fail in such cases. Do we want to authorize that? If we bypass the > error checks in appendShellString with an extra option, and have > initdb use that, the generated command would be actually correct. > -- > Michael >
