On Thu, Aug 18, 2016 at 9:30 AM, Ryan Murphy <ryanfmur...@gmail.com> wrote: (please avoid top-posting)
>> As far as I know, it is perfectly possible to have LF/CR in a path >> name (that's bad practice btw...), and your patch would make initdb >> fail in such cases. Do we want to authorize that? If we bypass the >> error checks in appendShellString with an extra option, and have >> initdb use that, the generated command would be actually correct. > > That's a fair point Michael. I would be willing to make such a change, but > since c doesn't have optional function arguments I'm not sure the least > intrusive way to do that. Do you have a suggestion? You could just add a boolean flag to appendShellString called for example no_error that the code path of initdb sets to true, and the other ones to false. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
