Hello Kyotaro-san,

[...] Agreed that copying statement string would be too much. But the new *Stmt node should somehow have also the end location of the statement since the user of a parse tree cannot look into another one.

Yes. I was thinking of adding a "length" field next to "location", where appropriate.

So I'm rather still in favor of my initial proposal, that is extend
the existing location information to statements, not only some tokens.

I thought that it's too much to let all types of parse node have
location but grepping the gram.y with "makeNode" pursuaded me to
agree with you.

Indeed...

After changing all *Stmt nodes, only several types of nodes seems missing it.

Yes. I'll try to put together a patch and submit it to the next CF.

--
Fabien.


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to