0;115;0c On 2017-03-11 22:14:07 -0500, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > On 2017-03-11 11:48:31 -0800, Andres Freund wrote: > >> I think that'd be a good plan. We probably should also keep --outputdir > >> seperate (which test_decoding/Makefile does, but > >> pg_isolation_regress_check doesn't)? > > > Here's a patch doing that (based on yours). I'd be kind of inclined to > > set --outputdir for !isolation tests too; possibly even move tmp_check > > below output_iso/ output_regress/ or such - but that seems like it > > potentially could cause some disagreement... > > This looks generally sane to me, although I'm not very happy about folding > the "$(MKDIR_P) output_iso" call into pg_isolation_regress_check --- that > seems weird and unlike the way it's done for the regular regression test > case.
Yea, not super happy about that either - alternatively we could fold it into pg_regress. But given the way that prove_checks works, I thought it'd not be too ugly comparatively. - Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
