On 23 Apr 2014, at 19:30, Marcus Denker <marcus.den...@inria.fr> wrote:
> > On 23 Apr 2014, at 19:21, Camille Teruel <camille.ter...@gmail.com> wrote: > >> >> On 23 avr. 2014, at 19:00, Marcus Denker <marcus.den...@inria.fr> wrote: >> >>> >>> On 23 Apr 2014, at 18:34, Marcus Denker <marcus.den...@inria.fr> wrote: >>> >>>> >>>> On 23 Apr 2014, at 18:18, Sven Van Caekenberghe <s...@stfx.eu> wrote: >>>> >>>>> And we're all GREEN, great work ! >>>>> Let's keep it that way until release. >>>>> Everything that breaks a test should now be reverted. >>>>> >>>> Yes! >>>> >>>> there are just two issues that are for pharo3 with fixes: >>>> >>>> >>>> https://pharo.fogbugz.com/f/cases/13028/Adding-ClassVariables-corrupts-class-hierarchy >>>> >>> >>> Ok, so loading that one brakes *everything*. >>> >>> (the build did not get done, so no problem, other than a red build) >>> >>> I will revert tomorrow... >> >> Arg, I'm sick of that issue. >> So do we try to integrate it in two passes? >> > > I have no idea what goes wrong… it seems that it works fine when I merge the > slice. > But then the update process (which just saved the packages…) does something > wrong. > > Mayeb we could try to have a version without the method that sends > #explicitRequirement > I integrated the issue as a change set (so there is some load order bug related to Traits with MC…). This seems to have worked: all image tests are green. BUT: the Metacello Platformtests fail with a “should not happen” error. https://ci.inria.fr/pharo/job/Pharo-3.0-Update-Step-2.3-MetacelloValidation/label=linux-stable-worker/388/consoleText (it would have been nice to have integrated this issue 2 weeks ago…) Fetched -> Metacello-TestsPlatform.squeakCommon-dkh.11 --- github://dalehenrich/metacello-work:master/repository --- github://dalehenrich/metacello-work:master/repository[31mError: Should not happen [0mLayoutEmptyScope(Object)>>error: LayoutEmptyScope(LayoutAbstractScope)>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: FixedLayout(ObjectLayout)>>reshapeFrom:to: ClassModificationPropagation>>propagate:to: ClassModificationPropagation class>>propagate:to: ClassModification(AbstractClassModification)>>propagate in Block: [ :subclass | propagations add: (ClassModification...etc... Metaclass>>subclassesDo: in Block: [ :aSubclass | ... Array(SequenceableCollection)>>do: MCFileTreeFileUtils class(Class)>>subclassesDo: Metaclass>>subclassesDo: ClassModification(AbstractClassModification)>>propagate SlotClassBuilder>>applyAndUpdateSharedVariableOrSharedPool: in Block: [ :old :new | ... SlotClassBuilder>>track:during: SlotClassBuilder>>applyAndUpdateSharedVariableOrSharedPool: SlotClassBuilder>>applySharedVariableOrPoolChange: SlotClassBuilder>>apply: SlotClassBuilder>>build PharoClassInstaller class(AbstractClassInstaller class)>>make: OldClassBuilderAdapter>>name:inEnvironment:subclassOf:type:instanceVariableNames:classVariableNames:poolDictionaries:category: MCClassDefinition>>createClass in Block: [ ... BlockClosure>>on:do:
