Derick Rethans wrote:
On Wed, 23 Oct 2002, Yasuo Ohgaki wrote:


Edin Kadribasic wrote:

Ok. Let's agree that the current implementation is not ideal, but it works. There were already several suggestions on how this can be improved, but I don't think this is the right time to start doing it.

So my proposal is that Yasuo reverts his patch until 4.3.0 is branched and then let's have a look at how to solve CLI ini/flush issues.
No problem, since the hard coded setting is over written
by php.ini under almost all UNIX environment.

Then what was the point in removing it in the first place? It's just a default.
Yes, since it should not set in php_cli.c.
It's a lot confusing, bad thing to do with current code,
inefficient, bad default, etc.

In addition, I'm suspecting there is serious bug in overall
ini handling in current code also. It was actually overriding
php.ini and set PG(implict_flush)=1 when I was tried to
fix output buffer flushing, but php.ini overrides the setting
now. I didn't realize until now, but there should be something
wrong. (or fixed? ;)


Before I do, as Murkas pointed out, we are better to check
how Windows users affected by this. I'll add the setting
few days later.

What setting do you need to add at all? You can disable this flushing:
1. with a -d parameter
It works.

2. in the script with ini_set()
I've pointed out _MANY_ times that PG(implicit_flush)
is INI_SYSTEM|INI_PERDIR....

I start doubting you weren't reading my mail at all
and replying.

--
Yasuo Ohgaki



--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to