As a user, I have no problem with a provided base test class using PHPUnit. Using PHP's run-tests.php would be a step backwards in my opinion.
However, I do agree that putting this into the package itself was a mistake, as was the version bump. It should be a -util package, as others have mentioned. -- Woody Gilk https://shadowhand.me On Tue, Dec 11, 2018 at 8:42 AM Sara Golemon <p...@golemon.com> wrote: > On Friday, December 7, 2018 at 10:19:46 AM UTC-6, Rasmus Schultz wrote: >> >> How is this in any way acceptable? >> > > I'm strongly in favor of tests being in the same package as the thing > being testing, and CI runs against that being part of the commit process, > so in THAT one way I'd call it "acceptable". > However, I absolutely see your point about tying it to a specific testing > framework, even if that framework is the de facto standard for composer > based PHP projects. > > Would you be less bothered by this if it were driven by PHP's own > run-tests.php ? That would give us reliable testing without any > framework-favoring dependencies (depending on PHP is an avoidable given, > after all). > > >> I'm calling for a bugfix release to remove these ASAP. >> >> I disagree with the urgency. Yes it's bad, and yes we should address > fixing it, but nothing is broken *right now*, so we don't need to rush into > it. > > -Sara > > -- > You received this message because you are subscribed to the Google Groups > "PHP Framework Interoperability Group" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to php-fig+unsubscr...@googlegroups.com. > To post to this group, send email to php-fig@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/php-fig/a81c3c57-d084-4e47-a7ba-799af33d0ee5%40googlegroups.com > <https://groups.google.com/d/msgid/php-fig/a81c3c57-d084-4e47-a7ba-799af33d0ee5%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group. To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+unsubscr...@googlegroups.com. To post to this group, send email to php-fig@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAGOJM6K2y24pMC7NJa59B52NkZQM9XznAt4N5BxW%2BWVpW0j2Tg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
