Re: [PHP-DOC] Livedocs

[Jakub Vrana]

Gabor Hojtsy wrote:
> The tableless layout for the manual is here:
>    http://www.php.net/manual/en/tableless/index.php
> It displays quite fine in Mozilla & Firefox, but is problematic in IE,
> since it does not interpret the float model correctly. I would be happy
> to see patches for this though :)) I definitely expect this to be fixed,
> and that livedocs should use this layout.

If the only problems are that there is a horizontal scrollbar and Prev
and Next sections don't have margins, here is my proposal:

1. Don't float .manualnavbar at right.
2. Swap the order of .prev and .next, and .langchooser and .langupdated
and don't float .prev and .langchooser at left.
3. Don't clear .manualnavbar HR.
4. Remove .cleaner from .manualnavbar.

This style is also simpler in my eyes. Tested with IE 6 and Opera 7.23.
I hope it works in other browsers too but I didn't test it.

Patch for phpweb is attached.

Jakub Vrana
Index: include/shared-manual.inc
===================================================================
RCS file: /repository/phpweb/include/shared-manual.inc,v
retrieving revision 1.216
diff -u -r1.216 shared-manual.inc
--- include/shared-manual.inc   3 Aug 2004 19:12:53 -0000       1.216
+++ include/shared-manual.inc   27 Aug 2004 11:58:53 -0000
@@ -244,21 +244,26 @@
     global $PGI, $LANG, $LANGUAGES, $INACTIVE_ONLINE_LANGUAGES;
 
     // Start navbar with 
-    echo "<!--UdmComment-->\n<div class=\"manualnavbar\">\n <span class=\"prev\">\n";
-    if ($PGI['prev'][1]) {
-        echo "  <a href=\"{$PGI['prev'][0]}\">" . 
-             make_image('caret-l.gif', '&lt;') .
-             $PGI['prev'][1] . "</a>\n";
-    }
-    echo " </span>\n <span class=\"next\">\n";
+    echo "<!--UdmComment-->\n<div class=\"manualnavbar\">\n <span class=\"next\">\n";
     if ($PGI['next'][1]) {
         echo "  <a href=\"{$PGI['next'][0]}\">" .
              $PGI['next'][1] .
              make_image('caret-r.gif', '&gt;') .
              "</a>\n";
     }
+    echo " </span>\n <span class=\"prev\">\n";
+    if ($PGI['prev'][1]) {
+        echo "  <a href=\"{$PGI['prev'][0]}\">" . 
+             make_image('caret-l.gif', '&lt;') .
+             $PGI['prev'][1] . "</a>\n";
+    } else {
+        echo "  &nbsp;\n";
+    }
     echo " </span>\n <hr />\n";
 
+    // Provide last updated information on this page
+    echo " <span class=\"lastupdated\">Last updated: {$PGI['lastmod']}</span>\n";
+
     // Print out language switch on top of manual pages
     echo " <div class=\"langchooser\">\n";
     if ($location != 'bottom') {
@@ -295,12 +300,12 @@
              '/images/small_submit.gif" border="0" width="11" height="11" ' .
              'alt="" align="baseline"> version of this page' . "\n  </form>\n";
        
+    } else {
+        echo "  &nbsp;\n";
     }
     echo " </div>\n";
 
-    // Provide last updated information on this page anc close div
-    echo " <span class=\"lastupdated\">Last updated: {$PGI['lastmod']}</span>\n" .
-         "<div class=\"cleaner\"></div>\n</div>\n<!--/UdmComment-->\n\n";
+    echo "</div>\n<!--/UdmComment-->\n\n";
 }
 
 // =============================================================================
Index: styles/site.css
===================================================================
RCS file: /repository/phpweb/styles/site.css,v
retrieving revision 1.14
diff -u -r1.14 site.css
--- styles/site.css     1 Aug 2004 16:21:05 -0000       1.14
+++ styles/site.css     27 Aug 2004 11:39:59 -0000
@@ -455,7 +455,6 @@
 
 /* Top and bottom navigation controls on manual pages --------------------- */
 div.manualnavbar {
-       float: right;
        background-color: #e0e0e0;
        color: inherit;
        padding: 4px;
@@ -468,7 +467,6 @@
        text-decoration: underline;
 }
 div.manualnavbar .prev, div.manualnavbar .langchooser {
-       float: left;
        padding-right: 4px;
 }
 div.manualnavbar .next, div.manualnavbar .lastupdated {
@@ -478,7 +476,6 @@
 div.manualnavbar hr {
        color: #cccccc;
        background-color: #cccccc;
-       clear: both;
 }
 div.manualnavbar form {
        margin: 0px;