Hi Yannick On 23 June 2010 18:36, Yannick Torrès <yannick.tor...@gmail.com> wrote: > 2010/6/23 Peter Cowburn <petercowb...@gmail.com> >> >> On 22 June 2010 19:08, Philip Olson <phi...@roshambo.org> wrote: >> > Hello all, >> > >> > This proposal proposes the following: >> > >> > (1) Email the translation lists (doc-$lang) when a translation build is >> > broken >> > (A) Active translations daily >> > (B) Inactive translations weekly >> > (2) Email phpdoc@ when the English build is broken (daily) >> > >> > I don't expect many emails ;) Sound fine? Thoughts on improving this >> > idea? >> >> Sounds great! My only "improvement" would be to perhaps run the build >> test immediately after a commit (perhaps only email the author or a >> selected list of folks?) if that is feasible. > > There are 2 points who let me know it's not a good idea : > * The build process consume some memory and there is (can be) a "lot of > commit" via the editor
There is no requirement that the build process take place on the box that runs the editor, is there? I've been playing around with farming this sort of task out to "the cloud" but I'm not sure how folks would feel with non-php.net hardware. Then again, what does it matter between getting a broken build message soon after a commit, versus getting one within 24 hours of it being broken... daily (or even less frequent for less active translations) may well be "good enough". > * If 2 users who work on the same translations commit, we must put in a > pending queue the build process > > >> >> Folks should be >> checking the build before committing (I guess that cannot be the case >> with the online editor), but immediately after is the next best thing. > > We simply can't do that. But we introduice some weeks ago a new > functionnality witch allow user to check the xml of his file before saving. > As I have said when I put this online, we can imagine to not save a file who > have some xml syntax error. > >> >> > >> > Yannick added code to do this within web/doc-editor/, and it would >> > happen via cron on the editor box (pb11.php.net). >> > >> > Regards, >> > Philip >> > >> > > >
