Hi Irker,

I just review your patch, and I'm not totaly agree with it.

* About modification on this files :  js/ui/cmp/NotInENGrid.js ;
js/ui/cmp/PendingTranslateGrid.js
; js/ui/cmp/FilePanel.js ; js/ui/task/GetFileTask.js
No problem.



* About modification on this files : js/ui/cmp/PendingReviewGrid.js ;
js/ui/cmp/StaleFileGrid.js
; js/ui/cmp/ErrorFileGrid.js ;
Modification you propose disable the fact that the user can modify EN file
when he fix LANG file.
When you open a LANG file to update it, you see some typo into EN file, and
you must be able to fix it directly into the right panel. With your
modification, you must open it from "all files" module.
I thinks we must stay with the actual result for this 3 files.

Modifications for the others files are great for me.

Best,
Yannick




2011/9/7 Александр Москалёв <ir...@irker.net>

> Yannick, I attached file to this mail.
>
> It's without compressed files.
>
> With regards, Alexander Moskaliov
> ir...@irker.net
>
>
>
> 2011/9/7 Yannick Torrès <yannick.tor...@gmail.com>:
> > Hi Irker,
> > Could you please provide us the content of this patch ?
> > After review it, you can directly commit it into trunk.
> > Best,
> > Yannick
>

Reply via email to