Hi Alex, basically here's what I noticed: Let me give you a (live) example: 1. I have en and nl karma 2. When I go to "Patches for review(0)" (where the 0 is incorrect, but that's not the point right now) 3. I navigate down to 'guilhermeblanco', and right click on construct.xml in the tree, I can choose "Commit". And it works 4. When I navigate to user 'ch', and right click on a patch in the tree, I can NOT choose "commit" (why??)
Then in contrast: when instead of choosing commit, I click "Edit file", I get a dialog which shows me 3 options: - Validate Patch - Reject patch - edit file Whenever I click on validate or reject, I get told I don't have karma to change the owner. However, I CAN commit the patch via the method I mentioned earlier. The thing is: I don't understand why I can't change the owner, but CAN commit the patch. I also don't understand why I can commit patches by some logged in users, but not by others. Even though both patches are for the english tree. - Tul On 29 February 2012 19:51, Alexander Moskaliov <ir...@irker.net> wrote: > Seems strange. > > jesusruiz have es doc karma. > In this case only es lang or global admins can see "Commit" menu on > this user, user's patches, user's folders or user's files in "Patches > for review". > > I will try check it deeply tomorrow. > Please, Can you tell me on what directly "click commit patch" means in > your case? > > > With regards, Alexander Moskaliov > ir...@irker.net > > > > 2012/2/29 Maciek Sokolewicz <maciek.sokolew...@gmail.com>: > > > > I just tried to validate and apply this patch via edit.php.net, but got > the > > message 'You can't change file's owner. You must be a global > administrator > > or an administrator for this lang.' > > > > However, when checking the Patches for Review section, I can select the > user > > jesusruiz and click commit patch. Which works fine. > > > > So one of both is incorrect. I personally think I should be able to > validate > > such a patch anyway, and if not, I would like to request karma to be > able to > > :) > > > > Anyway: the patch is committed. Thank you for supplying this patch. >
