On Jun 2, 2012, at 10:02 AM, Hannes Magnusson wrote: > On Sat, Jun 2, 2012 at 5:36 PM, Peter Cowburn <petercowb...@gmail.com> wrote: >> On 2 June 2012 12:53, Hannes Magnusson <hannes.magnus...@gmail.com> wrote: >>> >>> Yep. +1 from me. >>> >> >> Excellent. I've committed your patches for PhD, the >> mysql_affected_rows() docs change, and mine for phpweb. I've also >> opened a ticket to track these changes (and conveniently forgot to >> reference it in the commits!) at https://bugs.php.net/62213 >> >> I guess, if the above hasn't caused everything to explode, the next >> step is to roll out the docs changes for the rest of the ext/mysql >> functions (Philip?). Also, do we want to get this into a PhD release; >> I believe this was mentioned earlier? > > Kudos! > > We'll see if things explode on docs.php.net in few hours. > If it works out allright we must rollout a new PhD release and deploy > it before Friday, otherwise we'll get weird issues when the mirrors > pick up the new version :)
Looks good. I also like that it's shown before the description. In the future we can think about soft vs hard deprecation but for now this works great. Also, I'll be updating all of ext/mysql before Friday. Regards, Philip
