[
https://issues.apache.org/jira/browse/PIVOT-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740957#action_12740957
]
Todd Volkert commented on PIVOT-75:
-----------------------------------
The patch looks pretty good. Comments are as follows:
1) I'd change local variable splitLocationRatio to be just splitRatio
2) I'd change the SplitPaneListener interface to have the method be called
splitRatioChanged
3) I'd code the skin to treat splitLimits as limiting the absolute value of the
splitter (vs. limiting the split ratio). While splitRatio makes more sense
than splitLocation, I think the limits of the splitter make more sense as real
pixel values.
4) I like Greg's idea to bag splitLimits and make SplitPane just respect the
min/max preferred width/height of its two components. If you want to make this
change in the patch as well, you can, or if you want to maintain split limits
in the patch and tackle one change per SVN commit, that makes sense too.
5) With respect to the rounding question, as long as the skin's consistent in
how it rounds (floor, ceil, round), then I think any of those are fine. Just
make sure to not go under 0 or over the max.
> SplitPane should have relative resize style
> -------------------------------------------
>
> Key: PIVOT-75
> URL: https://issues.apache.org/jira/browse/PIVOT-75
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 1.1
> Reporter: Noel Grandin
> Assignee: Niclas Hedhman
> Fix For: 1.3
>
> Attachments: PIVOT-75-Fix.patch
>
>
> For the occasion when SplitPanes are embedded inside each other, it would be
> nice if I could set the inner SplitPane's to relative-resize-mode i.e. when
> it's size is reduced or expanded, it should adjust the splitter location to
> maintain the relative sizes of the top/bottom components.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
