[
https://issues.apache.org/jira/browse/PIVOT-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742570#action_12742570
]
Greg Brown commented on PIVOT-75:
---------------------------------
This looks good to me. I'd say go ahead and submit it, though Todd may have
some additional comments since he was the original author.
Minor coding style comments:
- Don't include spaces between a cast operator and the operand
- Don't include a space after opening or before closing parentheses
- Don't include CRs before opening curly braces
- Include a CR after @Override and other annotations
- Include a CR in @param tags after the variable name
- Some additional CRs in TerraSplitPaneSkin#limitSplitLocation() might help
improve readability a bit
- Variable name in SplitPane.SplitPaneListenerList#splitRatioChanged() is still
previousSplitLocation - should be previousSplitRatio
- Does this TODO still apply? I think it is safe to remove:
// TODO: the size overrides are awaiting consensus from community.
We really need to write up a coding standards doc. :-) I do have an Eclipse
formatting profile that we can post to the site, though.
Also, you'll need to update references to "splitLocation" in WTKX files. I'll
attach a patch you can apply before you check in.
> SplitPane should have relative resize style
> -------------------------------------------
>
> Key: PIVOT-75
> URL: https://issues.apache.org/jira/browse/PIVOT-75
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 1.1
> Reporter: Noel Grandin
> Assignee: Niclas Hedhman
> Fix For: 1.3
>
> Attachments: PIVOT-75-Fix.patch, PIVOT-75-Fix2.patch,
> split_ratio.patch
>
>
> For the occasion when SplitPanes are embedded inside each other, it would be
> nice if I could set the inner SplitPane's to relative-resize-mode i.e. when
> it's size is reduced or expanded, it should adjust the splitter location to
> maintain the relative sizes of the top/bottom components.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
