One more thing, I am heading off for a meeting shortly, then tomorrow I am at a wedding the whole day, and Monday I have Qi4j brainstorm meeting all day, so feel free to push this forward without my help.
Cheers Niclas On Thu, Aug 13, 2009 at 2:01 PM, Todd Volkert (JIRA)<[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/PIVOT-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742728#action_12742728 > ] > > Todd Volkert commented on PIVOT-75: > ----------------------------------- > > I just reviewed this as well. It looks really good - I only noticed a few > things: > > 1) SplitPane.setSplitRatio() still uses previousSplitLocation - should be > previousSplitRatio > > 2) I'd say you can remove the overrides of the getters and setters for > min/max preferred size. SplitPaneSkin always reports a preferred size of 0,0 > - it's meant to only be used in cases where it's either not asked for its > preferred size of it's given an explicit preferred size. In either case, the > min/max preferred sizes aren't really in play. > > 3) In SplitPaneSkin.SplitterSkin.mouseMove(), the split ratio must be > calculated *after* limiting the split location. > > These and Greg's points are simple enough to fix that I'd say no need to > re-post a patch for review. How does this work if you have karma to commit > but aren't a committer? :) > >> SplitPane should have relative resize style >> ------------------------------------------- >> >> Key: PIVOT-75 >> URL: https://issues.apache.org/jira/browse/PIVOT-75 >> Project: Pivot >> Issue Type: Improvement >> Components: wtk >> Affects Versions: 1.1 >> Reporter: Noel Grandin >> Assignee: Niclas Hedhman >> Fix For: 1.3 >> >> Attachments: PIVOT-75-Fix.patch, PIVOT-75-Fix2.patch, >> split_ratio.patch >> >> >> For the occasion when SplitPanes are embedded inside each other, it would be >> nice if I could set the inner SplitPane's to relative-resize-mode i.e. when >> it's size is reduced or expanded, it should adjust the splitter location to >> maintain the relative sizes of the top/bottom components. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > -- Niclas Hedhman, Software Developer http://www.qi4j.org - New Energy for Java I live here; http://tinyurl.com/2qq9er I work here; http://tinyurl.com/2ymelc I relax here; http://tinyurl.com/2cgsug
