Hi to all,
in these days I'm doing (a long work, that requires many tests ...)
some tests on using another color set in Terra Skin.
As Greg said to me, i have to use the following instruction at the
beginning of startup method (for example I'm trying with KitchenSink,
to see the effect on all components):
Theme.setTheme(new
TerraTheme("org/apache/pivot/wtk/skin/terra/TerraTheme_test.json"));
Point 1:
I'd like to have a sample like this in a source, so what do you think
on put this instruction at least in the real Kitchen Sink class, put
put it commented ?
Or derive a class, like KitchenSinkDarkColors and put there (but many
things in the original KitchenSink should be moved to protected).
Or use another, new class (but in this case it's diffucult to see the
effect on all components) ...
Ah, to see the real color that labels have, could be interesting in
the kitchen_sink.wtkx to not override the color of some rollup labels,
for example first 1, 2 and 3 ...
Point 2:
I changed the existing TerraTheme_test.json, to have a dark color
scheme to see in this case if all is good (prom a visual point of
view) ... and maybe my colors are not the best, but some little things
have revealed, like pressed buttons aren't different from normal, etc
...
And for this, if i could have in the json file also an optional
multiplier (coefficient: 0.0 .. 1.0) for telling how much darken and
how much brighten ... wdyt (what do you think) ?
In any case, i think a useful reference for anyone needs a work like
this is to identify where standard colors are used inside the Terra
skin.
I searched inside many sources, and I identified most of them (i hope
:-) ), so what do you think on add a comment on this inside this json
file ? Like:
{ font: "Verdana 11",
colors: [
"#f2f2f2", // 1: foreground for label etc // verify if use
e5e5e5, but not bababa (less contrast)
"#2b2b2b", // 4: background for groups // verify if use
3d3d3d instead, or 303030
"#998e8a", // 7: borders, and some disabled elements
"#0a0a0a", // 10: background in input elements, tabs, etc //
this + 10% for background (= #242424) // verify if use 4d4d4d (or
better, 454545), or if invert 3d3d3d with 525252
"#f0751c", // 13: selection, link, expanders text, and labels
(overridden) // verify is keep cc6600
"#ff7300", // 16: background in option buttons, title bars, etc
"#851506", // 19: selection background
"#c13719" // 22: errors, invalid elements, etc
]
}
ok, removing my verify text ... it's still a work-in-progress, but I'd
like to have for the 1.3 release.
And maybe the same info could be written elsewhere in a document ...
could really help in these cases, and without addiding additional text
in the standard Terra json file.
Later I'll try with some of the Tango (Icon) Standard palette colors
... we use these icons, so could be e right effect for color
consistencies ...
Point 3:
for better consistency with similar elements, I've changed the default
color used for Rollups, this is the patch, should I apply ?
Index: src/org/apache/pivot/wtk/skin/terra/TerraRollupSkin.java
===================================================================
--- src/org/apache/pivot/wtk/skin/terra/TerraRollupSkin.java (revision
807916)
+++ src/org/apache/pivot/wtk/skin/terra/TerraRollupSkin.java (working copy)
@@ -188,7 +188,7 @@
public TerraRollupSkin() {
TerraTheme theme = (TerraTheme)Theme.getTheme();
- buttonColor = theme.getColor(9);
+ buttonColor = theme.getColor(1);
spacing = 4;
buffer = 4;
fill = false;
Point 4:
for better consistency, a general rule is / should to use as main
colors only Standard Palette Colors (one of the 8 base Terra colors,
given in the json file), but for some elements we should fix, like in
the TerraTextInputSkin (used colors 11 and 10 insteaf of 10 and 9) ...
but in this case re-running my kitchen sink i see no changes (is it
overridden in some place ? I've not seen where ... can you help me,
please).
AlertSkin uses 9 instead of 10 (or 4).
Sheet uses background 11 (with custom alpha) instead of 10.
And probably others ... suggestions ?
Starting (finally) to look better at all these sources, I see the
great (and long and complex) work made by Greg and Todd in last years
... very impressive !!
Bye,
Sandro
