Hi Greg,
>> Theme.setTheme(new
>> TerraTheme("org/apache/pivot/wtk/skin/terra/TerraTheme_test.json"));
>>
>> Point 1:
>> I'd like to have a sample like this in a source, so what do you think
>> on put this instruction at least in the real Kitchen Sink class, put
>> put it commented ?
If possible, I'd commit this line but commented (with a comment on
what it means), to simplify tests and to show others how to do this
... until I'll have time (for 1.3.x) to create such demo, ok ?
Ah, I'm satisfied of my dark test json file, can I commit (overwriting
the original) ?
>> Point 2:
> Todd is probably best suited to comment here.
Ok, I'll wait Todd answers ...
>> In any case, i think a useful reference for anyone needs a work like
>> this is to identify where standard colors are used inside the Terra
>> skin.
>
> I think it might be better to reference the scheme ID from each skin that
> uses it, rather than the other way around. In other words, document (in
> Javadoc) that TerraPushButtonSkin uses color 10 by default for the
> background color. Otherwise, we'll be maintaining this information in two
> places, and the JSON file could get messy.
Ok, but having a summary of how colors are used inside a test json
file like this could help color customizers, to have it as a sample,
without having to read JavaDoc for many classes ... and writing in the
json file that it's only a reference that could not reflect the
current status in Terra skin, ok ?
>> Point 3:
>> for better consistency with similar elements, I've changed the default
>> color used for Rollups, this is the patch, should I apply ?
>
> I think that looks too dark. The current color was actually chosen by a
> graphic designer - I think we should leave it as-is.
For consistency, I used the same default as Labels and other components.
In the current implementation (color) I think there is only little
contrast with default background of panels, so for me it hasn't much
visibility, and in the case of disabled rollup, the disabled color
could be too similar.
>> Point 4:
>> for better consistency, a general rule is / should to use as main
>> colors only Standard Palette Colors (one of the 8 base Terra colors,
>> given in the json file)
>
> The 8 base colors exist primarily to provide a simple way to define the
> other colors. All of the colors in the scheme are available for use (though
> they may not all be used at any given time).
Ok, but i think that a better graphic design rule is to work with only
base palette colors, except when i need a variation, like
hiliteBackground or disableBackground that should use directly the
variant of the base color.
But in any case, what do you think on changing default colors for
these components (described in my previous mail), to align on colors
already used with other components ?
Sandro
