Theme.setTheme(new
TerraTheme("org/apache/pivot/wtk/skin/terra/TerraTheme_test.json"));
Point 1:
I'd like to have a sample like this in a source, so what do you think
on put this instruction at least in the real Kitchen Sink class, put
put it commented ?
It might be better to create a simple demo (or tutorial) app that
shows how to do this. It could just be a few widgets (buttons, lists,
etc.) - just enough to demonstrate the effect. Maybe you could create
one! :-)
Point 2:
I changed the existing TerraTheme_test.json, to have a dark color
scheme to see in this case if all is good (prom a visual point of
view) ... and maybe my colors are not the best, but some little things
have revealed, like pressed buttons aren't different from normal, etc
This may just be a factor of how the scheme colors are determined. In
other words, maybe the Terra theme just isn't suited to dark base
colors. On the other hand, this may be something we can (fairly)
easily accommodate. Todd is probably best suited to comment here.
In any case, i think a useful reference for anyone needs a work like
this is to identify where standard colors are used inside the Terra
skin.
I searched inside many sources, and I identified most of them (i hope
:-) ), so what do you think on add a comment on this inside this json
file ? Like:
{ font: "Verdana 11",
colors: [
"#f2f2f2", // 1: foreground for label etc // verify if use
...
I think it might be better to reference the scheme ID from each skin
that uses it, rather than the other way around. In other words,
document (in Javadoc) that TerraPushButtonSkin uses color 10 by
default for the background color. Otherwise, we'll be maintaining this
information in two places, and the JSON file could get messy.
Point 3:
for better consistency with similar elements, I've changed the default
color used for Rollups, this is the patch, should I apply ?
I think that looks too dark. The current color was actually chosen by
a graphic designer - I think we should leave it as-is.
Point 4:
for better consistency, a general rule is / should to use as main
colors only Standard Palette Colors (one of the 8 base Terra colors,
given in the json file)
The 8 base colors exist primarily to provide a simple way to define
the other colors. All of the colors in the scheme are available for
use (though they may not all be used at any given time).
Thanks,
Greg
