This is a resend of a code review that was sent on Feb 7th. I haven't as
yet received any responses on this. Can someone please take a look?
Because of the changes that have been pushed since the 7th, it may be
necessary to do another remerge. Sorry that this delta is getting so
big. If a set of smaller deltas would be more palatable, I could
prepare it that way too.
Thanks.
Tom
All,
http://cr.opensolaris.org/~tmueller/ips-multi-3/index.html
I tooks the comments from James' previous reviews and have reintegrated
the changes with a more recent gate (one that includes the verify changes).
The new URL is above.
I also generated a "webrev of webrevs" showing the changes
I made since the last code review (after the merge) That's at:
http://cr.opensolaris.org/~tmueller/ips-multi-2-3-diffs/index.html
The changes are:
- Changes based on previous code review (includes refactoring of
portable module)
- Made ELF changes portable and optional
- Moved passwd and group file caching to portable module
- Added methods to portable interface for getting user and group names
(for verify method)
- Changed pkg, pkgsend, and pkg.depotd scripts (for use on Linux) to
exec python rather than running as a subprocess (needed to make unit
test cases work)
- changed the logic in setup.py and unit test cases for naming the build
and root directories - this allows all platforms to be built in the same
directory tree from a single source tree (SunOS names stay the same)
- added unit test case log file to setup.py (similar to how Makefiles work)
- added update.ksh test cases to unit tests on posix platforms (in setup.py)
- changed unit test cases to use /bin/ls rather than /lib/libc.so.1 as
the sample file
- added .5 second delays to update test cases due to lack of sufficient
granularity in the timedate.now() method on Windows. Granularity on
Windows is only 16ms so updates were being missed in the test cases
- fixed unit test cases for portable module - logic was wrong on Windows
for testing is_admin
- fixed bug in catalog.ts_to_datetime for the case where the microsecond
value is 0
Please review at your earliest convenience. Once these changes are ok,
I would like to have James push the changes.
Thank you.
Tom
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;SWI Install/Update Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
