> Because of the changes that have been pushed since the 7th, it may be 
> necessary to do another remerge.

You're required to merge with the tip before you push.

> http://cr.opensolaris.org/~tmueller/ips-multi-3/index.html

Most of this looks okay, but somebody besides me should also take a
look.

I mostly have nits now:

server/transaction.py:226 - Add a text message along with your error
code explaining that ELF files aren't supported.

image.py:581-593 - For me, at least, it's literally a pain to type
long function names with lots of underscores.  Is there a reason why
we're using get_user_by_name, get_name_by_uid, get_group_by_name, and
get_name_by_gid instead of getpwnam, getpwuid, getgrnam, and getgrgid?

Thanks,

-j

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to