[EMAIL PROTECTED] wrote:
Because of the changes that have been pushed since the 7th, it may be
necessary to do another remerge.
You're required to merge with the tip before you push.
Yes, definitely. I should have said that the remerge will get more
difficult the longer that this is outstanding.
http://cr.opensolaris.org/~tmueller/ips-multi-3/index.html
Most of this looks okay, but somebody besides me should also take a
look.
I mostly have nits now:
server/transaction.py:226 - Add a text message along with your error
code explaining that ELF files aren't supported.
Done. I added a message "ELF files are not supported on this server"
image.py:581-593 - For me, at least, it's literally a pain to type
long function names with lots of underscores. Is there a reason why
we're using get_user_by_name, get_name_by_uid, get_group_by_name, and
get_name_by_gid instead of getpwnam, getpwuid, getgrnam, and getgrgid?
In a previous review Danek (or was it really him? :-)) requested that
since the parameters
and return values were not the same as the methods with those names in
the os package,
the names should be different.
Thanks.
Tom
Thanks,
-j
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center/OpenInstaller Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
