The changes to provide portability to non-Solaris platforms have been
merged with the latest gate (as of Mar 18) and comments from the
previous review have been addressed.
Here are the webrevs:
Complete differences from the gate:
http://cr.opensolaris.org/~tmueller/ips-multi-4/
Differences since the Feb 7, 2008 review:
http://cr.opensolaris.org/~tmueller/ips-multi-3-4-diffs/
The ips-multi-3-4-diffs unfortunately also contains changes from other
changesets too in 4 files. I removed files that were not affected by my
changes, but I wasn't able to figure out a way to have webrev ignore the
changesets that affected the files that I had changed.
Here are the changes that were made since the last review:
- changed copyrights in all modified files to 2008
- removed blanks/tabs on empty lines
- changed import of pkg.elf to use boolean rather than trying to import
everytime (2 places)
- fixed file reading bug on windows (need to read file with "rb" mode)
(2 places)
- made new user and group actions portable to Windows (these actions are
ignored on Windows)
- changed portable module to not use classes to eliminate double
function calls (this works similar to how os.path works now)
- replaced /dev/null with os.devnull
- fixed setup.py to handle scripts and robots.txt file correctly
- fixed t_pkgtarfile test case to be portable
- increased delay for depot startup in two-depot.ksh to make test more
reliable
The unit tests have been run on Solaris, Windows, and Ubuntu (so far),
and pylint has been run.
Thank you.
Tom
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center/OpenInstaller Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
