On Wed, Mar 19, 2008 at 10:40:12AM -0500, Tom Mueller wrote:
> http://cr.opensolaris.org/~tmueller/ips-multi-3-4-diffs/
These are mostly nits now.
actions/user.py:
- line 172: no return value from remove()
portable/__init__.py:
- line 160: you can get rid of the need for impl_found, I think, by using
for/else: if you fall off the end of a for-loop, the optional else
clause will get executed. (If you break out of the for-loop, the else
clause is skipped.)
portable/os_darwin.py:
- line 29: I believe that if you put this in quotes instead of making it
a block comment, pydoc will pick this up as the module docstring. If
that works, it's worth doing. Same for the others.
portable/os_unix.py:
- line 126: it looks like this got lost in the last round:
if passwd_stamp <= users_lastupdate.get(dirpath, 0):
elfextract.c:
- line 376: you were going to change this to match the previous ifdef?
server/transaction.py:
- line 235: ready for the symbolic version of 501? Probably want to wrap
the line after the comma, too.
- line 236: thinking about this, I'm wondering if it should just ignore
the elf-special file handling and continue to store the file. If
you're not running into problems with this now, don't worry about it,
but the present behavior seems a bit odd.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
