On Mon 24 Mar 2008 at 11:45AM, Danek Duvall wrote:
> After doing a full install with these changes (or upgrading from 79), there
> are still four verification errors:
> 
>     PACKAGE                                             STATUS 
>     pkg://opensolaris.org/SUNWintgige                    ERROR
>             driver: e1000g
>                     extra minor node permission '* 0666 root sys' found in 
> etc/minor_perm
>     pkg://opensolaris.org/SUNWnge                        ERROR 
>             driver: nge
>                     extra minor node permission '* 0666 root sys' found in 
> etc/minor_perm
>     pkg://opensolaris.org/SUNWpsdcr                      ERROR 
>             driver: asy
>                     extra minor node permission '*,cu 0600 uucp uucp' found 
> in etc/minor_perm
>     pkg://opensolaris.org/SUNWafe                        ERROR \\ 
>             driver: afe
>                     extra minor node permission '* 0666 root sys' found in 
> etc/minor_perm
> 
> For e1000g, nge, and afe, this is because the base minor_perm contains one
> set of permissions, and the postinstall scripts for those packages contain
> a different set.  These need to be rectified.
> 
> The failure for asy is because it's absolutely impossible for any
> combination of add_drv and update_drv to install a minor perm with a comma
> in it.  If I put this perm in the driver action, the install complains (but
> leaves it in the base file).  If I leave it in the base file, then the
> install is okay, but the verify gives this warning.  Short of rewriting
> add_drv and update_drv, there's no fix.
> 
> This changeset also fixes a quick bug in the hardlink action.

Can you/have you file appropriate bugs against ON to go along with this
fix?

I think the new syntax could perhaps be a little nicer:

add driver name=dmfe perms="* 0666 root sys" clone_perms="dmfe 0666 root sys"

In "perms" the author gets to (must?) omit the name of the driver; in
clone_perms, it must be specified (since it names a minor node).
But AFAIK that's essentially a constant, and the clone minor name will
always match the driver name.  Is that the case?

I see two possible remedies here: get rid of clone_perms and make this
generic:

add driver name=dmfe perms="dmfe:* 0666 root sys" perms="clone:dmfe 0666 root 
sys

Or, in the clone action, presume that <drivername> is the node of the
clone driver you're talking about:

add driver name=dmfe perms="* 0666 root sys" clone_perms="0666 root sys"

It seems like there might be a useful opportunity to make a shortcut
here, BTW.   Something like network_drvperms="default" which would
auto-expand to the obvious defaults.

        -dp

-- 
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to