> I've put up a new webrev:
>
> http://cr.opensolaris.org/~dduvall/pkg-780-3/
Great work, Danek and thanks for fixing up the various drivers. I only
have a few comments:
src/util/distro-import/common/SUNWpcan
Nit - I believe we're pretty consistent about first defining
"perms" and then "clone_perms" but here we list them in the
opposite order. Of course, it makes no functional difference
but it would be nice to be consistent (I think this was the
only one arranged this way but you might want to double check.)
src/util/distro-import/i386/SUNWbge
Looks good but I just putback i386/SUNWbge.85 so could you make
the same change there please?
src/util/distro-import/i386/SUNWckr.84
Some of these drivers are not actually delivered by SUNWckr.
For example, "ptmx" is actually delivered by SUNWcs(u) while
"loop, tidg, tivc and tmux" are actually part of the unbundled
SUNWsvvs package.
Given that SUNWcs is installed in all zones, I suppose keeping
the driver action for "ptmx" in SUNWckr makes sense for now.
However, perhaps it makes sense to remove the others.
Also, since "ticlts, ticots and ticotsord" are minor nodes of
"tl", perhaps it makes sense to include that as well here:
add driver name=tl perms="* 0666 root sys"
Finally, it might be nice to sort this list of actions in this
file.
src/util/distro-import/i386/SUNWpsdcr
Looks like a second perms is missing: perms="*,cu 0600 uucp
uucp"
src/util/distro-import/i386/SUNWpsdir
Looks like a perms field is missing: perms="* 0600 root sys"
dsc
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
