On Sun, Mar 30, 2008 at 11:15:34PM -0700, [EMAIL PROTECTED] wrote:
> src/util/distro-import/common/SUNWpcan
>
> Nit - I believe we're pretty consistent about first defining
> "perms" and then "clone_perms" but here we list them in the
> opposite order. Of course, it makes no functional difference
> but it would be nice to be consistent (I think this was the
> only one arranged this way but you might want to double check.)
Fixed.
> src/util/distro-import/i386/SUNWbge
>
> Looks good but I just putback i386/SUNWbge.85 so could you make
> the same change there please?
Fixed.
> src/util/distro-import/i386/SUNWckr.84
>
> Some of these drivers are not actually delivered by SUNWckr.
> For example, "ptmx" is actually delivered by SUNWcs(u) while
> "loop, tidg, tivc and tmux" are actually part of the unbundled
> SUNWsvvs package.
>
> Given that SUNWcs is installed in all zones, I suppose keeping
> the driver action for "ptmx" in SUNWckr makes sense for now.
> However, perhaps it makes sense to remove the others.
Fixed.
> Also, since "ticlts, ticots and ticotsord" are minor nodes of
> "tl", perhaps it makes sense to include that as well here:
>
> add driver name=tl perms="* 0666 root sys"
Fixed. Though if those three are minor nodes of tl, perhaps we should
treat them as such:
add driver name=tl perms="* 0666 root sys" clone_perms="ticlts 0666 root
sys" ...
which would mean implementing the idea I had for extending the clone_perms
attribute to allow for either three or four words. Thoughts?
> Finally, it might be nice to sort this list of actions in this
> file.
Fixed.
> src/util/distro-import/i386/SUNWpsdcr
>
> Looks like a second perms is missing: perms="*,cu 0600 uucp
> uucp"
Unfortunately, we can't do that; the update_drv is completely nonplussed by
the comma there. We're going to have to live without this until the _drv
utils are overhauled.
> src/util/distro-import/i386/SUNWpsdir
>
> Looks like a perms field is missing: perms="* 0600 root sys"
Fixed.
Thanks for the review. There's a new webrev up at
http://cr.opensolaris.org/~dduvall/pkg-780-4/
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
