On Tue, Apr 08, 2008 at 01:40:10PM -0700, [EMAIL PROTECTED] wrote:
> http://cr.opensolaris.org/~johansen/pkg-sslcli/
client.py
- usage() takes an argument which is the error to print. Looks like all
of your calls to usage() with a print immediately before them should
just move that string into the usage() call.
- line 890, 1040: spaces around equals signs.
- line 908, 913: could use error()
- line 942, 944: these two lines are the same; take them out of the if?
image.py
- line 315: how do you remove a key (or a cert or a mirror, etc) from an
authority?
- line 567: should this be outside the if?
- line 774: you don't reset cat each time through the loop. Is that
problematic? You might consider pushing these two lines (removing the
"if cat" test up into the previous if.
retrieve.py
- line 73: "manifest", not "file"
misc.py
- line 41: why not "if u[-1] != '/':"?
urlhelpers.py
- need standard stuff at beginning of file (#!, CDDL, copyright, phone #)
- line 1: "supplement"
- line 30: 8-space indent
ssl-headers.conf
- too many X-SSL-PROTOCOL lines?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
