On Tue, Apr 08, 2008 at 03:24:34PM -0700, [EMAIL PROTECTED] wrote:
> > client.py
> >
> > - line 942, 944: these two lines are the same; take them out of the if?
>
> Which two lines? Can you either clarify or give me more context? I'm
> having a hard time making sense of this comment.
Lines 942 and 944. Except that now they appear to be 939 and 941. Did you
update the webrev? They're the ones that say
print "%15s %30s" % (pfx, url)
I'm suggesting you dedent line 939, and get rid of lines 940 and 941. In
the, uh, new, uh, non-drunk numbering scheme.
> > image.py
> >
> > - line 315: how do you remove a key (or a cert or a mirror, etc) from an
> > authority?
>
> Right now, you unset the authority and create a new one. You could also
> edit the cfg_cache by hand. What's the use case for removing a cert?
That's a fine answer. Removing a cert? Dunno. Perhaps you decided it
wasn't worth running an SSL server.
> > - line 567: should this be outside the if?
>
> No. If it's outside the if, you'll return None as the authority in all
> situations where we don't re-write the format of the installed file.
>
> I'll add a comment here, so this isn't so confusing.
Don't worry about it (either way, if you've done it already); I didn't
spend much time thinking it through.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
