Hi Shawn,Sorry I'm a bit too busy to review your changes at the moment, but I did want to tell you that I think I own a bug 1?? which is related to the SMF property names, so you may want to check that out too.
Trev Shawn Walker wrote:
2008/5/21 Shawn Walker <[EMAIL PROTECTED]>:2008/5/20 Shawn Walker <[EMAIL PROTECTED]>:2008/5/11 Shawn Walker <[EMAIL PROTECTED]>:The following webrev includes proposed fixes for the following bugs: 1854 rework depot to use higher-level framework 1154 pkg.depotd tracebacks when given bad options 1237 pkg.depotd -p 80 -p 90 should return usage, but second option is taken 1887 depot status page output is not valid HTML 1888 memleaks test overwrites PYTHONPATHNewly added: 1956 depotd performance hampered by unnecessary getpwuid/getgrgid callsNewly added: 1889 pkg.depotd(1M) man page specifies incorrect smf(5) property names 2021 depotd --rebuild doesn't work if specified before -d Reasons for new webrev: * I realised after the last webrev that I had forgotten to update the usage message and man pages for the new -s option I added so you could control how many threads to serve requests were started. As such, it made sense to fix 1889 while I did that. * I happened to see bug 2021 and realised that my command-line option parsing fixes would not be complete without fixing this as well. Changes since last webrev: * Updated man page to document the previously added -s option. * Updated SMF manifest to add pkg/threads property for -s option. * Added CherryPy's *.tar.gz to hgignore. * Moved rebuild/readonly and repository configuration logic to happen after all command-line options have been successfully parsed. * Moved and simplified comments for socket timeout. * Simplified quickstart() call to start server. To make it easier to see the changes since the last webrev, I have created a special diff: http://cr.opensolaris.org/~swalker/pkg-depot-8/raw_files/pkg-depot-8.patch New webrev: http://cr.opensolaris.org/~swalker/pkg-depot-8/ I apologise for adding yet another set of changes to this already long review. I should have thought of these earlier. Cheers,
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
