I changed the block comment before this section to read as follows: # On Windows, rename to existing file is not allowed, so the # destination file must be deleted first. But if the destination file # is locked, it cannot be deleted. Windows has 3 types of file locking # # 1. Using share access controls that allow applications to specify # whole-file access sharing for read, write or delete; # 2. Using byte range locks to arbitrate read and write access to # regions within a single file; and # 3. By Windows file systems disallowing executing files from being # opened for write or delete access. # # The code here deals only with locks of type 3. If the lock on the open # file is for a running executable, then the destination file can be renamed # and deleted later when the file is no longer in use. For a rename to a # destination locked with type 1 or 2, rename throws an OSError exception. #
Tom Shawn Walker wrote: > 2008/6/23 Tom Mueller (pkg-discuss) <[EMAIL PROTECTED]>: > >> 3. By Windows file systems disallowing executing files from being >> opened for write or delete access. >> >> This fix only deals with files locked with type 3. With the first two >> types, there is no way to actually do anything at all with the file. >> Thus, the update is going to fail because an exception is going to be >> thrown from line 161. >> > > Should a comment be added to indicate that this only deals with that > specific case and that there are two others? > > Otherwise, this still looks good to me. > > Cheers, > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
