On Tue, Jun 24, 2008 at 04:40:50PM -0500, Tom Mueller (pkg-discuss) wrote: > I changed get_trashdir as follows (added an if to check if the > cached_image is suitable)
Okay. > The Update Center updatetool has support for multiple user images as one of > its primary features. It manipulates multiple images from a single process. Then wouldn't you want one trash directory and one cached image for each image you're dealing with? Seems like what you have would only deal with whichever happened to be the latest one that called get_trashdir(). Seems a bit ... nondeterministic. If that's sufficient, fine, but I would put in a comment making that explicit, as it feels really weird. >> Please junk the last empty line in os_windows.py. > > I added this to make webrev stop complaining about a missing newline at > the end of the file. I'll delete the line before checking this in. Is this a CRLF vs CR issue? Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
