Danek Duvall wrote: >> The Update Center updatetool has support for multiple user images as one of >> its primary features. It manipulates multiple images from a single process. >> > > Then wouldn't you want one trash directory and one cached image for each > image you're dealing with? Seems like what you have would only deal with > whichever happened to be the latest one that called get_trashdir(). Seems > a bit ... nondeterministic. If that's sufficient, fine, but I would put in > a comment making that explicit, as it feels really weird. > The trash directories need to be per-image because the images might be on different disks. If I could have just one trash directory, I'd just put it in the users temporary file area.
I'm assuming that a user will typically work with one image for a while, performing various updates, installs, etc. before switching to another image. So keeping track of many cached images didn't seem worth the extra code. Having the one cached image will allow all of the renames for a single update/install to proceed efficiently. > >>> Please junk the last empty line in os_windows.py. >>> >> I added this to make webrev stop complaining about a missing newline at >> the end of the file. I'll delete the line before checking this in. >> > > Is this a CRLF vs CR issue? > I don't think so. I'm doing editing and running webrev on Solaris 10. Windows only comes into play for build/test. Thanks. Tom _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
