Dan Price wrote: > On Tue 22 Jul 2008 at 03:57PM, Brock Pytlik wrote: > >> This is a fix for 1753 where depots can be left running by the test >> suite. These changes ensure that tearDown is always at least attempted >> by any subclass of ManyDepotTestCase. I was torn on whether to do a >> normal tearDown, or just kill off the depots. I chose to use tearDown >> for code resuse, but if that's not what we actually want to happen, I'll >> make it so only the depots are killed. >> >> Since Brad is also planning on subclassing unittest, it seemed rational >> to place all those changes in a single location, so I'm using >> baseline.py as he suggested. >> >> Here's the bug: >> http://defect.opensolaris.org/bz/show_bug.cgi?id=1753 >> >> And the code: >> http://cr.opensolaris.org/~bpytlik/ips-1753/ >> > > So... is line 520 in testutils.py really supposed to be commented > out? > > I have to confess that this code is making my brain hurt. > > -dp > > Ack, no, it shouldn't be commented out. Sorry about that, I must've misread the test output...
New webrev at http://cr.opensolaris.org/~bpytlik/ips-1753-v1 Are there places where I could put more comments in to make it less painful? Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
