On Tue, Jul 22, 2008 at 03:57:48PM -0700, Brock Pytlik wrote:
> http://cr.opensolaris.org/~bpytlik/ips-1753/
My main comment here is on the names. I'd rename baseline.py to be
pkg5testcase.py. "Baseline" is too tightly coupled to the meaning of the
known state of the tests. Likewise, BaselineTestCase should be called
Pkg5TestCase. And cli/testutils.py should rename Pkg5TestCase to
CLITestCase or something.
testutils.py:
- line 523: should we warn that we failed to tear down the depots?
Trying once and silently giving up doesn't seem like the right way
forward here.
t_setUp.py:
- lines 46, 51: docstring needs changing
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
