Brock Pytlik wrote: > New webrev is up which is resynced with the gate and has updated > baselines. The baselines are functionally the same except that two new > tests are supposed to pass. > > CR is at: > http://cr.opensolaris.org/~bpytlik/ips-1753-v2/
http://cr.opensolaris.org/~bpytlik/ips-1753-v2/src/tests/cli/t_setUp.py.html ========== 47 raised during setUP. s/setUP/setUp/ 53 """Test whether the first depot was shut down. If this test 54 raises a exception because a depot was already running on that 55 port, then the test has failed. If it raises the 56 SuccessfulException, then it has passed because it was able to 57 successfully start a depot.""" Nitpick: current standard is to have two spaces after each '.' in sentences. More descriptive names for the test functions would be nice. http://cr.opensolaris.org/~bpytlik/ips-1753-v2/src/tests/cli/testutils.py.wdiff.html ========== 517 + if result is None: result = self.defaultTestResult() Nitpick: A new line after ':' would be nice. http://cr.opensolaris.org/~bpytlik/ips-1753-v2/src/tests/pkg5unittest.py.wdiff.html ========== 56 + if result is None: result = self.defaultTestResult() Nitpick: A new line after ':' would be nice. 89 + if ok: result.addSuccess(self) Nitpick: A new line after ':' would be nice. Otherwise looks fine. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
