Brad Hall wrote: > On Fri, Jul 25, 2008 at 09:52:46AM -0700, Danek Duvall wrote: >> On Thu, Jul 24, 2008 at 04:09:43PM -0700, Brad Hall wrote: >> >>> Link to new CR: http://cr.opensolaris.org/~bhall/bug-2627-1/ > > Updated with Danek's requested changes. > > New webrev: http://cr.opensolaris.org/~bhall/bug-2627-2/
http://cr.opensolaris.org/~bhall/bug-2627-2/src/tests/baseline.py.html ========== 32 the current state of the source tree.""" Move the """ down to the next line for all of your docstrings like this for PEP8... 37 # dict of "test name" -> "result" 38 results = {} 39 # Filename to store the results 40 filename = "" 41 # 'generating' keeps track of whether we are currently generating 42 # a baseline or not: if either the baseline doesn't exist or the 43 # "-g" option is specified on the commandline. 44 generating = False 45 # List of tuples (name, result) for failed tests 46 failed_list = [] Can you add a few blank lines in between these commented sections to increase readability? 83 and their result""" Missing '.' at end of sentence. Move the """ down to the next line. http://cr.opensolaris.org/~bhall/bug-2627-2/src/tests/pkg5unittest.py.html ========== 62 res = "pass (fail)" Shouldn't fail be "all caps" here to match lines 83 and 85 (and to make it more obvious)? Otherwise, I think your changes look good. -- Shawn Walker | Solaris Development | [EMAIL PROTECTED] | blogs.sun.com/srw _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
