On Thu, Jul 24, 2008 at 05:38:58PM -0700, Dan Price wrote:
> Cool.  This is looking very good.  When you post your webrev, I'll
> do a pass through the code in more depth.
> 
> I thought I wrote these down, but discovered that I didn't.  A few
> more questions: How do you handle:
> 
>         - tests in the baseline but which didn't run

Not sure what you mean here -- didn't run because they error'd?

>         - tests which ran but aren't in the baseline

Currently not handled.  Though we could easily print something near the test
such as:
foo.py Testcase                                         pass
*** Testcase is not in the baseline; please regenerate ***

Or something like that.
 
> And, would it be possible to have a command line arg for providing a
> path to an alternate baseline?

At the moment there is two baseline files (cli, and api), which in retrospect
doesn't make that much sense.  So I can merge those into one file then provide
a command line option (-b, or something) that allows the user to specify a
baseline.

New webrev (with your previous suggestions) is posted here: 
http://cr.opensolaris.org/~bhall/bug-2627-1/

Thanks,
Brad
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to