Brad Hall wrote: > On Thu, Jul 24, 2008 at 05:38:58PM -0700, Dan Price wrote: > >> Cool. This is looking very good. When you post your webrev, I'll >> do a pass through the code in more depth. >> >> I thought I wrote these down, but discovered that I didn't. A few >> more questions: How do you handle: >> >> - tests in the baseline but which didn't run >> > > Not sure what you mean here -- didn't run because they error'd? > > Tests might have been combined, or moved to a different module or even removed if they were redundant (for example). When I looked at your code, I was pretty sure that this case would just report that a difference had been noticed (which seems reasonable to me), but if you have more detailed baseline comparisons, it might be helpful to break these into a different category.
Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
