Brock Pytlik wrote: > Dan Price wrote: >> On Tue 29 Jul 2008 at 06:28PM, Brock Pytlik wrote: >> >>> Oops, hadn't realized that. I've made the change in t_search.py as well >>> which had used assert (all the tests still pass). >>> >>> New cr at: http://cr.opensolaris.org/~bpytlik/ips-2693-v2/ >>> >> Ok, I'm now satisfied. It'd be nice to get a second pair of eyes if >> possible. >> >> > Indeed, I'll wait for one more person to check off on this.
http://cr.opensolaris.org/~bpytlik/ips-2693-v2/src/modules/catalog.py.wdiff.html ========== 114 + assert not (read_only and rebuild) Nitpick: the lisp-y madness (parentheses) 127 + if rebuild == None: Nitpick: We have 28 occurrences of "is None" and 37 occurrences of "== None". I have no particular preference, but consistency would be nice. Just wanted to point that out so folks are conscious of it... Other than the comments others have made, I have nothing more to add and am happy to see these changes. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
