Shawn Walker wrote:
> Brock Pytlik wrote:
>> Dan Price wrote:
>>> On Tue 29 Jul 2008 at 06:28PM, Brock Pytlik wrote:
>>>  
>>>> Oops, hadn't realized that. I've made the change in t_search.py as 
>>>> well which had used assert (all the tests still pass).
>>>>
>>>> New cr at: http://cr.opensolaris.org/~bpytlik/ips-2693-v2/
>>>>     
>>> Ok, I'm now satisfied.  It'd be nice to get a second pair of eyes if
>>> possible.
>>>
>>>   
>> Indeed, I'll wait for one more person to check off on this.
>
> http://cr.opensolaris.org/~bpytlik/ips-2693-v2/src/modules/catalog.py.wdiff.html
>  
>
> ==========
>
>       114 +                assert not (read_only and rebuild)
>
So, not (a and b) != not a and b

 >>> a = True
 >>> b = False
 >>> not (a and b)
True
 >>> not a and b
False

This is one time where the parens are necessary.
>
> Nitpick: the lisp-y madness (parentheses)
>

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to