Danek Duvall wrote:
> On Tue, Jul 29, 2008 at 06:28:00PM -0700, Brock Pytlik wrote:
>
>
>> New cr at: http://cr.opensolaris.org/~bpytlik/ips-2693-v2/
>>
>
> t_depotcontroller.py:
>
> - the first and second test clauses in testBadArgs() are identical, I
> think. Is that intentional?
>
Bleh, that was intentional at the time, but not supposed to make it into
the final version.
> depotcontroller.py:
>
> - does start_expected_fail() need to kill the server if sleeptime meets
> its max?
>
yes, good point
> - And perhaps sleeptime should max out at 1, so that we only wait two
> seconds, rather than four.
>
>
Ok
>
Stephen had mentioned that we were still printing out the catalog on
> startup, as we acquired it. I couldn't find the code that was doing that.
> Did you find it, or confirm that it isn't doing that anymore and that
> Stephen is just smoking something?
Ah, that's line 351 in catalog.py. Doesn't have to be this wad. In fact,
we shouldn't generally run into it, so the indication that something's
amiss (even if slightly) may not be the worst thing in the world.
So, should I leave the line in that case? If we're deploying by just
dumping packages in the pkg subdir, but not also pushing an updated
catalog, then I'd expect to see this issue (or if we're pushing the
catalog file before we push the packages, but if this were the case,
then add_fmri would be raising an exception, right?).
Thanks,
Brock
> Danek
>
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
