[EMAIL PROTECTED] wrote: > Shawn Walker wrote: >> 457 + auths[auth_name]["mirrors"].append(mirror) >> >> What about a try: except: to handle the auth_name not existing? > > How would that happen? We check to make sure the authority exists in > client.py. It returns an error if it can't be found. I've updated the > error message in that part of the code to be more clear.
Bad usage of a "public" API? I have no strong feeling about this; my habit just tends to be to have every public API method assert things. Maybe an assert here instead? >> http://cr.opensolaris.org/~johansen/pkg-mirror1/src/modules/client/imageconfig.py.wdiff.html >> ========== >> Nitpick: Why isn't it bad_tx and good_tx instead of errors and good_tx? > > I think "errors" is more descriptive. That's fine, I just wanted to ensure it was intentionally done that way. -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
