[EMAIL PROTECTED] wrote:
> I have integrated the feedback from Shawn and Brock into a new webrev.
> You can take a look at it here.
> 
> http://cr.opensolaris.org/~johansen/pkg-mirror2/
> 
> If anybody else is interested in reviewing this, or wants more time,
> please speak up now.  Otherwise, I'll push this change soon.

I don't see the "--add-mirror and --remove-mirror" in your new webrev. 
Was that intentional?  You'll need tests too if not...

What about an SMF option for --mirror? Can you log a bug for at least?

I suppose it faces the same difficulty as the one for --readonly (bug 2717).

Otherwise, looks fine.

-- 
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to